Redirect to the login view when login is required #1733
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
UMAP_ALLOW_ANONYMOUS
setting is False, we return the login url through a JSON response. We lost that ability in #1555.The JS part was not following that link in that particular case and lead to more errors because the map was not saved (hence, no
map_id
).For now, the current work on the map is lost because of the redirection and we have a confirmation dialog to quit the edited page with unsaved changes.
Maybe we should display a custom message instead of a brutal redirection? Like: you’re not logged in, do it in a separate tab to keep you work? (A bit ugly…)
Sidenote: we might want to use the
redirect
pattern/key in the JSON response that we already use for deletion and clone for consistency.